[No QA] Revert "Revert "Fix miss-matched SMS email suffix on sign in page"" #15606

yuwenmemon · 2023-03-02T00:42:09Z

@luacmartins @AndrewGable or @roryabraham please revire
cc @Julesssss

Reverts #15604 - this was not the performance regression culprit.

Tests/QA Steps

Already performed here: #15351

Verify that no errors appear in the JS console

Offline tests

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari.mp4

Desktop

desktop.mp4

iOS

ios-app.mp4

Android

android-app.mp4

MelvinBot · 2023-03-02T00:42:45Z

@marcaaron Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

roryabraham · 2023-03-02T01:34:16Z

Reviewer Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

No screenshots included for this straight revert-of-a-revert

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

MelvinBot · 2023-03-02T01:35:48Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2023-03-02T01:39:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2023-03-02T02:09:39Z

Performance Comparison Report 📊

Significant Changes To Duration

Name	Duration
Open Search Page TTI	609.257 ms → 661.490 ms (+52.232 ms, +8.6%) 🔴

Show details

Name	Duration
Open Search Page TTI	Baseline Mean: 609.257 ms Stdev: 22.977 ms (3.8%) Runs: 581.2825530003756 583.6676030000672 585.8352459995076 586.8741050008684 587.4405930005014 587.7458899999037 590.9017740003765 591.5517580006272 592.0468760002404 593.7633880004287 595.4440919999033 596.4484459999949 598.0743810003623 598.4697269992903 599.7901210002601 600.9352219998837 602.3293460002169 605.0104569997638 606.5245779994875 610.123128999956 612.4237879998982 615.2019859999418 616.0739750005305 617.1263429997489 618.7882489999756 619.8297939999029 629.8796390006319 645.9691570000723 649.999715000391 650.9037679992616 653.4979659998789 672.2746179997921 Current Mean: 661.490 ms Stdev: 13.169 ms (2.0%) Runs: 641.349813000299 643.5762120001018 645.6422529993579 645.7183029996231 645.9253739994019 646.9502770006657 649.3138439999893 650.113647999242 653.760377000086 656.0544440001249 656.472820000723 656.5974540002644 657.0253090001643 658.8972180001438 659.5040689995512 661.3666179999709 663.4800620004535 663.9394939998165 664.1423750007525 664.8482260005549 666.0099289994687 666.2565509993583 667.3977870000526 668.2905279994011 670.6724040005356 672.466878999956 682.637532999739 683.5826420001686 691.1457519996911 691.5469570001587

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	694.702 ms → 714.499 ms (+19.798 ms, +2.8%)
App start runJsBundle	192.188 ms → 192.516 ms (+0.329 ms, ±0.0%)
App start nativeLaunch	19.742 ms → 19.813 ms (+0.071 ms, ±0.0%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.001 ms, +4.9%)

Show details

Name	Duration
App start TTI	Baseline Mean: 694.702 ms Stdev: 32.815 ms (4.7%) Runs: 625.6935609998181 649.4330599997193 651.2695620004088 655.7674380000681 662.4497119998559 662.8298209998757 665.1045409999788 668.1218929998577 668.8321449998766 673.6551069999114 675.2260119998828 677.5373959997669 681.3185729999095 683.4402780001983 684.7968410002068 691.6089399997145 694.4558579996228 699.5076980004087 699.8951040003449 700.2315880004317 705.7931880000979 706.5733529999852 709.0892719998956 714.101921999827 723.4884280003607 729.480550000444 738.5608329996467 741.2744990000501 742.2643630001694 744.933028999716 748.0603210004047 755.6612689998001 Current Mean: 714.499 ms Stdev: 33.460 ms (4.7%) Runs: 667.81365799997 668.590386999771 675.177285999991 678.0981459999457 683.0431650001556 685.5267040003091 689.18633600045 689.2463830001652 689.606724999845 694.2613439997658 696.2966369995847 697.3677260000259 701.4002090003341 701.5083720004186 703.725321999751 704.2548479996622 708.186405999586 708.423267999664 712.774507000111 714.7203219998628 715.6170079996809 717.1752289999276 721.3757600001991 730.9081640001386 735.6820839997381 742.268380000256 742.9971500001848 754.6040979996324 770.9257030002773 784.0099769998342 788.236375999637 790.9698109999299
App start runJsBundle	Baseline Mean: 192.188 ms Stdev: 22.647 ms (11.8%) Runs: 160 162 162 162 164 167 172 173 174 174 178 182 184 188 188 190 190 195 196 198 202 204 207 207 207 209 210 211 224 226 229 255 Current Mean: 192.516 ms Stdev: 17.441 ms (9.1%) Runs: 165 168 170 170 173 174 176 179 180 182 183 187 189 191 191 192 192 193 194 194 200 201 201 204 206 209 209 212 213 234 236
App start nativeLaunch	Baseline Mean: 19.742 ms Stdev: 1.950 ms (9.9%) Runs: 17 18 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 20 20 21 21 21 22 22 24 24 25 Current Mean: 19.813 ms Stdev: 1.648 ms (8.3%) Runs: 17 18 18 18 18 18 18 18 19 19 19 19 19 19 19 19 20 20 20 20 20 21 21 21 21 21 21 22 22 22 23 24
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.001 ms (7.3%) Runs: 0.012409999966621399 0.012531999498605728 0.0125730000436306 0.012653999961912632 0.012776000425219536 0.012980000115931034 0.013021000660955906 0.013141999952495098 0.013143000192940235 0.013143000192940235 0.013306000269949436 0.013306000269949436 0.01342800073325634 0.01358999963849783 0.013632000423967838 0.01375299971550703 0.013794000260531902 0.013875000178813934 0.013956000097095966 0.014038999564945698 0.014078999869525433 0.014283000491559505 0.014322999864816666 0.014322999864816666 0.0143630001693964 0.014689000323414803 0.015340999700129032 0.015421999618411064 0.015461999922990799 0.016032000072300434 0.016397999599575996 Current Mean: 0.015 ms Stdev: 0.001 ms (7.6%) Runs: 0.012614000588655472 0.013182999566197395 0.013265000656247139 0.013345999643206596 0.013387000188231468 0.013590999878942966 0.013631000183522701 0.013632000423967838 0.013712999410927296 0.013793999329209328 0.013956000097095966 0.0139979999512434 0.014038000255823135 0.014038000255823135 0.014322999864816666 0.014403999783098698 0.014485000632703304 0.014485999941825867 0.014526000246405602 0.014648000709712505 0.01469000056385994 0.014973999932408333 0.015054999850690365 0.015095999464392662 0.015137000009417534 0.015258999541401863 0.015461999922990799 0.015542999841272831 0.0165200000628829 0.0166830001398921 0.0167239997535944 0.017171000130474567

github-actions · 2023-03-02T02:09:43Z

@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker.

OSBotify · 2023-03-02T23:16:16Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-06T15:37:53Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Revert "Revert "Fix miss-matched SMS email suffix on sign in page""

c1acd52

yuwenmemon self-assigned this Mar 2, 2023

yuwenmemon requested a review from a team as a code owner March 2, 2023 00:42

melvin-bot bot requested review from marcaaron and removed request for a team March 2, 2023 00:42

yuwenmemon requested review from luacmartins, AndrewGable and roryabraham March 2, 2023 00:43

roryabraham approved these changes Mar 2, 2023

View reviewed changes

roryabraham merged commit 84e37e6 into main Mar 2, 2023

roryabraham deleted the revert-15604-revert-15351-jules-fixAndAlignSMSSuffix branch March 2, 2023 01:35

melvin-bot bot added the Emergency label Mar 2, 2023

github-actions bot added the DeployBlockerCash This issue or pull request should block deployment label Mar 2, 2023

OSBotify mentioned this pull request Mar 2, 2023

Deploy Checklist: New Expensify 2023-03-02 #15618

Closed

35 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Revert "Revert "Fix miss-matched SMS email suffix on sign in page"" #15606

[No QA] Revert "Revert "Fix miss-matched SMS email suffix on sign in page"" #15606

yuwenmemon commented Mar 2, 2023 •

edited

Loading

MelvinBot commented Mar 2, 2023

roryabraham commented Mar 2, 2023 •

edited

Loading

MelvinBot commented Mar 2, 2023

OSBotify commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

OSBotify commented Mar 2, 2023

OSBotify commented Mar 6, 2023

[No QA] Revert "Revert "Fix miss-matched SMS email suffix on sign in page"" #15606

[No QA] Revert "Revert "Fix miss-matched SMS email suffix on sign in page"" #15606

Conversation

yuwenmemon commented Mar 2, 2023 • edited Loading

Tests/QA Steps

Offline tests

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 2, 2023

roryabraham commented Mar 2, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

MelvinBot commented Mar 2, 2023

OSBotify commented Mar 2, 2023

github-actions bot commented Mar 2, 2023

Performance Comparison Report 📊

Significant Changes To Duration

Meaningless Changes To Duration

github-actions bot commented Mar 2, 2023

OSBotify commented Mar 2, 2023

OSBotify commented Mar 6, 2023

yuwenmemon commented Mar 2, 2023 •

edited

Loading

roryabraham commented Mar 2, 2023 •

edited

Loading